Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#163] created contribution detail page #171

Merged
merged 3 commits into from
Jul 3, 2024
Merged

[#163] created contribution detail page #171

merged 3 commits into from
Jul 3, 2024

Conversation

Madhavdua
Copy link
Contributor

Closes:

  • Title : Created contribution detail page
  • Name: Madhav Dua
  • **Idenitfy yourself:**SSOC Contributor

Created detail page as asked.

Type of change ☑️

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • [x ] My code follows the Contributing Guidelines & Code of Conduct of this project.
  • [x ] This PR does not contain plagiarized content.
  • [x ] I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • [ x] My changes generate no new warnings.

Screenshots 📷

Screenshot 2024-06-30 021444

Note to reviewers 📄

Kindly review it and merge it

@vercel Vercel
Copy link

vercel bot commented Jun 29, 2024

@Madhavdua is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@vercel Vercel
Copy link

vercel bot commented Jun 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 4:24am

Avdhesh-Varshney
Avdhesh-Varshney requested changes Jun 30, 2024
View reviewed changes
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhavdua design the details page and show the details of only merged prs. like, it's title, assigned labels, redirecting button, etc. a proper card arrangement of contributors merged prs.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 30, 2024
@Madhavdua
Copy link
Contributor Author

For each merged PR:
1.Title
2.Labels, each with descriptions.
3.Seperate redirect link
4.Creation and closed date

Here's the screenshot:
Screenshot 2024-07-01 232336

Avdhesh-Varshney
Avdhesh-Varshney approved these changes Jul 3, 2024
View reviewed changes
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhavdua looks interesting. PR Approved 🎉

@Avdhesh-Varshney Avdhesh-Varshney merged commit 8f67456 into Avdhesh-Varshney:main Jul 3, 2024
4 checks passed
@Avdhesh-Varshney
Copy link
Owner

@Madhavdua properly link your issue. I've mentioned you so many times.

@Avdhesh-Varshney Avdhesh-Varshney linked an issue Jul 3, 2024 that may be closed by this pull request
🧑‍💻: Contributor detail page #163
Closed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement 🧑‍💻 New feature or request Approved ✔️ This PR is approved by the PR or, Mentors Intermediate Intermediate level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24 and removed bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avdhesh-Varshney Avdhesh-Varshney Avdhesh-Varshney approved these changes

Assignees

@Madhavdua Madhavdua

Labels
Approved ✔️ This PR is approved by the PR or, Mentors enhancement 🧑‍💻 New feature or request Intermediate Intermediate level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧑‍💻: Contributor detail page
2 participants
@Madhavdua @Avdhesh-Varshney